[alsa-devel] [PATCH] PCM parameters in file plugin

Takashi Iwai tiwai at suse.de
Thu Jan 29 12:01:32 CET 2009


At Thu, 29 Jan 2009 11:54:18 +0100,
Pavel Hofman wrote:
> 
> Takashi Iwai wrote:
> > 
> > Thanks, it gets better now.
> > 
> >> +static int snd_pcm_file_replace_key(char format, const void *value_p,
> >> +		char **string_p, char **index_ch_p, int *len_p)
> > 
> > I think it could be easier to make value_str in the caller side.
> > That is,
> > ........
> 
> Hi Takashi,
> 
> Thanks for your valuable comments. I am enclosing a fixed and tested 
> version.

Thanks for a quick fix!  Now I applied your patch to GIT tree.
For further improvements / optimizations, please submit a patch
against it.


Takashi


More information about the Alsa-devel mailing list