[alsa-devel] [Pull request] Support for wm9705 codec and two machines that use it.
ian at mnementh.co.uk
Fri Jan 16 12:34:41 CET 2009
Takashi Iwai wrote:
> At Thu, 15 Jan 2009 10:06:53 +0000,
> Ian Molton wrote:
> Shouldn't be this "reg >= ARRAY_SIZE(wm9705_reg)" ?
Looks that way. Will fix.
I've spotted the same error in a couple of other drivers too.
It looks like register caching is a very common thing, would you be
interested in a patch that consolidates the cache handling in soc-core,
rather than having multiple possibly broken implementations around?
Also, I could be wrong, but wm8980 caching looks completely broken
(array is type u16 but there is no register shift applied, AFAICT)
fixed in wm9705 for now anyway.
> Ditto, should be "reg < ARRAY_SIZE(wm9705_reg)".
> You can use kmemdup() here.
More information about the Alsa-devel