[alsa-devel] [PATCH 1/1] ASoC: Fix compilation error with davinci-sffsdr module
hugo at hugovil.com
Wed Jan 14 21:54:06 CET 2009
On Tue, 6 Jan 2009 22:00:06 +0000
Mark Brown <broonie at sirena.org.uk> wrote:
> On Tue, Jan 06, 2009 at 04:41:20PM -0500, Hugo Villeneuve wrote:
> > Mark Brown <broonie at sirena.org.uk> wrote:
> > > If the driver is for is not yet in mainline I'd be more inclined
> > > to fix this by providing the relevant Kconfig dependency to
> > > exclude it
> > The problem is that some people may want to do modifications to this
> > soc driver, and they won?t be able to test that their changes are
> > valid (ex: do not break compilation).
> Speaking as the person who I expect most frequently tries that I
> wouldn't worry about it - it's easy enough to see what's happened and
> there will still be errors at link time even with the extern.
No, there won´t be errors when compiling as a module. Only when
actually loading the module.
> I'd certainly want to see the Kconfig fix as well, independantly of
I will look into this eventually.
> > > Do the DaVinci drivers build at all in mainline, anyway? Last
> > > time I checked they required out of tree DMA patches.
> > I just sucessfully compiled the davinci-sffsdr soc driver (although
> > audio seems broken for me at the moment when I actually test it).
> That's good news - previously it would fail to build at all. What
> sort of breakage are you seeing (and what was the version you used
> when you developed the driver)?
I developped the driver with version 2.6.27-rc6-davinci1-05187-g91c2c53.
The breakage I see when I run the aplay utility is this:
aplay: pcm_write:1394: write error: Input/output error
davinci-git version is the latest as of january 14
> [Your MUA isn't doing word wrapping, BTW.]
Fixed, thanks :)
More information about the Alsa-devel