[alsa-devel] [PATCH 2/2] Add initial support of Mitac mioa701 master volume.
broonie at sirena.org.uk
Thu Jan 8 21:46:31 CET 2009
On Thu, Jan 08, 2009 at 07:42:26PM +0100, Robert Jarzmik wrote:
> Depending on the "Mio Mode" chosen, the master volume
> controls the widget volume/mute levels, providing userspace
> a unified vision of volume control (one control only).
I've not got time to review this properly tonight so I'll just say that
the comments about scenario stuff in my previous mail apply here - if we
want to do this in kernel it's worth lifting out the generic bits of
code so that other machine drivers don't end up implementing the same
> The master volume is adapted to smartphones because :
> - it abstracts to userland audiopath within the chip
Yeah, applications should really be able to see such an abstraction -
it'd make them work a lot better with ASoC cards.
The main concern with doing it in drivers specifically is that this
means the driver needs to know about all the possible scenarios which
gets hard when the user can run their own programs and think up their
own use cases. It also makes configuring scenarios a bit harder since
you can't tweak the paths with alsamixer so easily, though that's
> +static struct snd_kcontrol *kctrl_byname(struct snd_soc_codec *codec, char *n)
> + struct snd_ctl_elem_id rid;
> + memset(&rid, 0, sizeof(rid));
> + rid.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
> + strncpy(rid.name, n, sizeof(rid.name));
> + return snd_ctl_find_id(codec->card, &rid);
I'm fairly sure you had the same thing in your machine driver -
definitely worth abstracting regardless of anything else (probably even
worth putting a version in ALSA core, I guess).
More information about the Alsa-devel