[alsa-devel] longname in sound/core/jack.c

Takashi Iwai tiwai at suse.de
Wed Feb 18 14:40:09 CET 2009


Mark,

I'm not sure whether I've already asked it, but I find it ugly to
refer to card->longname for the input device name in
sound/core/jack.c.
Can it be changed to card->shortname, at least?

The long name is often really long like "HDA Intel at 0xf8400000 irq
21", thus the resultant name will be
   "HDA Intel at 0xf8400000 irq 21 Line Out at Ext Left"
as the jack name.


Takashi

---
diff --git a/sound/core/jack.c b/sound/core/jack.c
index 43b10d6..c8254c6 100644
--- a/sound/core/jack.c
+++ b/sound/core/jack.c
@@ -55,7 +55,7 @@ static int snd_jack_dev_register(struct snd_device *device)
 	int err;
 
 	snprintf(jack->name, sizeof(jack->name), "%s %s",
-		 card->longname, jack->id);
+		 card->shortname, jack->id);
 	jack->input_dev->name = jack->name;
 
 	/* Default to the sound card device. */


More information about the Alsa-devel mailing list