[alsa-devel] [PATCH] ALSA: hda - Cleanup setting of pin_configs in patch_stac927x

Takashi Iwai tiwai at suse.de
Thu Feb 12 00:20:25 CET 2009


At Wed, 11 Feb 2009 20:33:15 -0200,
Herton Ronaldo Krzesinski wrote:
> 
> After commit "ALSA: hda - Fix restore of pin configs at resume for
> STAC/IDT codecs", the introduced stac_save_pin_cfgs function checks
> already for pins == NULL case, saving then default pin configs from
> machine with stac92xx_save_bios_config_regs. So we can remove the
> extra checks when stac927x_brd_tbl[spec->board_config] == NULL.
> 
> Signed-off-by: Herton Ronaldo Krzesinski <herton at mandriva.com.br>

Applied now.  Thanks.


Takashi

> ---
>  sound/pci/hda/patch_sigmatel.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index 12b3088..6fa064d 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -5292,10 +5292,9 @@ static int patch_stac927x(struct hda_codec *codec)
>  							stac927x_models,
>  							stac927x_cfg_tbl);
>   again:
> -	if (spec->board_config < 0 || !stac927x_brd_tbl[spec->board_config]) {
> -		if (spec->board_config < 0)
> -			snd_printdd(KERN_INFO "hda_codec: Unknown model for"
> -				    "STAC927x, using BIOS defaults\n");
> +	if (spec->board_config < 0) {
> +		snd_printdd(KERN_INFO "hda_codec: Unknown model for"
> +			    "STAC927x, using BIOS defaults\n");
>  		err = stac92xx_save_bios_config_regs(codec);
>  	} else
>  		err = stac_save_pin_cfgs(codec,
> -- 
> 1.6.1.3
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 


More information about the Alsa-devel mailing list