[alsa-devel] [PATCH] alsa: snd_pcm_new api cleanup
tiwai at suse.de
Thu Feb 5 12:29:45 CET 2009
At Thu, 5 Feb 2009 12:27:15 +0100,
Tim Blechmann wrote:
> Impact: cleanup
> snd_pcm_new takes a char *id argument, although it is not modifying
> the string. it can therefore be declared as const char *id.
> Signed-off-by: Tim Blechmann <tim at klingt.org>
> sound/core/pcm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> diff --git a/sound/core/pcm.c b/sound/core/pcm.c
> index 192a433..583453e 100644
> --- a/sound/core/pcm.c
> +++ b/sound/core/pcm.c
> @@ -692,7 +692,7 @@ EXPORT_SYMBOL(snd_pcm_new_stream);
> * Returns zero if successful, or a negative error code on failure.
> -int snd_pcm_new(struct snd_card *card, char *id, int device,
> +int snd_pcm_new(struct snd_card *card, const char *id, int device,
> int playback_count, int capture_count,
> struct snd_pcm ** rpcm)
Don't forget to fix include/sound/pcm.h, too.
Or, more better, please test the build once before submitting patches :)
More information about the Alsa-devel