[alsa-devel] [PATCH] pcm_oss: AFMT_S24_LE is set twice in return value

Takashi Iwai tiwai at suse.de
Wed Feb 4 18:26:34 CET 2009


At Wed, 04 Feb 2009 18:14:55 +0100,
Roel Kluin wrote:
> 
> vi sound/core/oss/pcm_oss.c +640
> #define AFMT_S24_LE      0x00008000
> #define AFMT_S24_BE      0x00010000
> 
> ---------------------->8----------------------8<-------------------
> AFMT_S24_LE is set twice in return value
> 
> Signed-off-by: Roel Kluin <roel.kluin at gmail.com>

Thanks, applied now.


Takashi

> ---
> diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
> index e178366..0a1798e 100644
> --- a/sound/core/oss/pcm_oss.c
> +++ b/sound/core/oss/pcm_oss.c
> @@ -1767,7 +1767,7 @@ static int snd_pcm_oss_get_formats(struct snd_pcm_oss_file *pcm_oss_file)
>  		       AFMT_S8 | AFMT_U16_LE |
>  		       AFMT_U16_BE |
>  			AFMT_S32_LE | AFMT_S32_BE |
> -			AFMT_S24_LE | AFMT_S24_LE |
> +			AFMT_S24_LE | AFMT_S24_BE |
>  			AFMT_S24_PACKED;
>  	params = kmalloc(sizeof(*params), GFP_KERNEL);
>  	if (!params)
> 


More information about the Alsa-devel mailing list