[alsa-devel] [PATCH 2/4] ASoC: pxa-ssp: PXA2xx/3xx SSP ports start from 1, not 0

Mark Brown broonie at sirena.org.uk
Tue Feb 3 18:35:14 CET 2009

On Tue, Feb 03, 2009 at 06:13:22PM +0100, pHilipp Zabel wrote:

> -       priv->dev.ssp = ssp_request(dai->id, "SoC audio");
> +       priv->dev.ssp = ssp_request(dai->id + 1, "SoC audio");
>         if (priv->dev.ssp == NULL) {
>                 ret = -ENODEV;
>                 goto err_priv;

> But this isn't right either. Because if we request the correct SSP
> port here, the subsequent request of the same SSP port in ssp_init
> (called from ops->startup) fails.
> How to fix?

Hrm.  ssp_init() does a ssp_request() already.  The request on probe is
just redundant.  Eric was muttering about refactoring the API some more
but never got round to it.

"You grabbed my hand and we fell into it, like a daydream - or a fever."

More information about the Alsa-devel mailing list