[alsa-devel] [PATCH] sscape: drop redundant fields from soundscape struct

Takashi Iwai tiwai at suse.de
Mon Feb 2 08:23:55 CET 2009

At Sun, 1 Feb 2009 21:12:31 +0100,
Krzysztof Helt wrote:
> The midi_vol is set only to 0 so it does not work
> as detection of change in midi volume. It is removed.

It's used to cache the value.  You should better to keep it, but fix
sscape_midi_put() function to remember the last
uctl->value.integer.value[0] value in this field.
(And also better to change sscape_midi_get() to return midi_vol

Other changes look good.



More information about the Alsa-devel mailing list