[alsa-devel] Confusion about whether snd_pcm_poll_descriptors_revents()'s revents field is a single integer or an array
tiwai at suse.de
Mon Feb 2 08:02:29 CET 2009
At Mon, 2 Feb 2009 03:50:22 +0100,
Lennart Poettering wrote:
> If we look into the pcm example how snd_pcm_poll_descriptors_revents()
> is used then we can see that the revents parameter apparently is
> supposed to be a single integer. (which makes a lot of sense to me)
> However, snd_pcm_wait_nocheck() calls the same function and assumes it
> is a complete array!
> So what's it now? It makes more sense to me if it would be a single
No, it's a bug in test/pcm.c. As documented, the API converts (fixes)
each poll_fd in the given array.
> The problem becomnes visible if someone writes a plugin that wants
> wakeups from more than one fd because either snd_pcm_wait() using
> applications start to act weirdly because the revents are not fully
> initialized or snd_pcm_poll_descriptors_revents() using applications
> get invalid memory accesses.
> This has become visible in the Bluetooth plugin.
> I guess nobody has written a plugin that has more than one fd to sleep
> on yet, right?
Right, it hasn't been a big problem just because it's a pretty rare
More information about the Alsa-devel