[alsa-devel] [PATCH 2/2] ASoC: Add FSI-DA7210 sound support for SuperH
broonie at opensource.wolfsonmicro.com
Thu Dec 10 10:44:23 CET 2009
On 10 Dec 2009, at 02:17, Kuninori Morimoto <morimoto.kuninori at renesas.com
> Dear Mark
>>> +#define DA7210_BUS 0
>>> +#define DA7210_ADR (0x34 >> 1)
>>> +static int da7210_add_i2c_device(void)
>> This should be being done by the arch code rather than here, and
>> no code to remove the device on shutdown. This idiom has been used
>> some drivers as part of a transition from the old style ASoC stuff
>> the I2C device was registered in the CODEC to reduce cross tree
>> but it's best to avoid it for new code.
> I should modify ak4642 / fsi-ak4642 too
Yes, please. It's not super urgent but it'd be a nice cleanup.
More information about the Alsa-devel