[alsa-devel] [PATCH] ASoC: S3C platform: Fix s3c2410_dma_started() called at improper time

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Aug 25 12:33:29 CEST 2009

On Tue, Aug 25, 2009 at 11:04:26AM +0800, Shine Liu wrote:

>      I think before we fix the bug in the callback way, we can use this
> patch provisionally for a while though it seems a little ugly. 

I can't prevail on you to do this with a callback within the ASoC code
only?  This really does seem like something that's created by the way
ASoC is structured rather than a general S3C DMA issue so I'm not sure
that the arch/arm code needs to be changed at all.

Otherwise the patch looks OK, in fact I'd tone down the comments about
it being a hack to do this - ASoC DAI and PCM drivers are supposed to be
fairly closely tied to each other.

More information about the Alsa-devel mailing list