[alsa-devel] [PATCH] ASoC: s3c24xx platform: Fix s3c2410_dma_started called at wrong time

Shine Liu shinel at foxmail.com
Mon Aug 24 15:31:28 CEST 2009

> But why are you changing the core DMA code in the first place?  The ASoC
> drivers have split front end and DMA code but this is not the normal
> case for a DMA client.

I think your idea of the callback is very elegant and I appreciate this
way to solve the problem so I try to add new API for the core DMA to
achive this goal.

Well, if there are two arguments for the callback function passed though
struct struct s3c2410_dma_client, it's also reasonable. If there are
more arguments to pass, maybe this is not the best solution. Use a
internal struct to wrapper more arguments into one object and pass the
pointer is just a candidate. 

More information about the Alsa-devel mailing list