[alsa-devel] [PATCH] ASoC: s3c24xx platform: Fix s3c2410_dma_started called at wrong time

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Aug 20 12:15:50 CEST 2009

On Thu, Aug 20, 2009 at 05:42:11PM +0800, Shine Liu wrote:

> In the current framework, s3c24xx_pcm_trigger() is always called before
> s3c24xx_pcm_trigger(). So the s3c2410_dma_started() should be called in
> s3c24xx_pcm_trigger() after s3c24xx_snd_txctrl(1) or
> s3c24xx_snd_rxctrl(1) is called in this function.

I suspect some of the function names in your description here are
incorrect :) Another option is to provide a callback in the private data
passed to the DMA driver which the DMA driver can call at the
appropriate point during setup.

Someone will presumably also need to take care of the same things in the
other S3C DAI drivers too, though it should be possible to arrange
things so that can be done seperately.

More information about the Alsa-devel mailing list