[alsa-devel] [PATCH V2 1/3] new ad1836 codec driver based on asoc

[Mark Brown]

On Thu, Aug 13, 2009 at 11:59:32AM +0800, Barry Song wrote:
> There has been an ad1836 driver in sound/blackfin based on traditional alsa.
> The new driver is based on asoc. The architecture of ad1836 codec driver is
> very much like ad1938.

> Signed-off-by: Barry Song <21cnbao at gmail.com>

This is pretty much there - the issues below are very small so I'll
apply this and fix up everything except the driver name as I do.

> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -68,6 +68,9 @@ config SND_SOC_AC97_CODEC
>  	tristate
>  	select SND_AC97_CODEC
>  
> +config SND_SOC_AD1836
> +	tristate
> +
>  config SND_SOC_AD1938
>  	tristate

Sorry, missed this first time round - this should also add to
SND_SOC_ALL_CODECS.

> +static struct spi_driver ad1836_spi_driver = {
> +	.driver = {
> +		.name	= "ad1836-spi",

I thought the conclusion from the discussion earlier was that this
should have the -spi dropped (or did that discussion cross in the post
with the patch)?

> +struct snd_soc_codec_device soc_codec_dev_ad1836 = {
> +	.probe = 	ad1836_probe,
> +	.remove = 	ad1836_remove,
> +	/* The power management of ad1836 is very simple. There are
> +	 * only adc&dac 2 components to control. Dapm handles them.
> +	 */
> +	.suspend =      NULL,
> +	.resume =       NULL,

I'll remove the suspend/resume methods here.