[alsa-devel] [PATCH 0/2] ASoC: TWL4030: Cosmetic and PM related changes

Peter Ujfalusi peter.ujfalusi at nokia.com
Thu Aug 13 14:59:32 CEST 2009


I'm not sure, if the first patch is acceptable by ASoC standards, but:
Before the patch the analog capture path strings ended up like this at the end:
"Analog Left Capture Route Main mic Switch"
These switches showed up in the playback tab of alsamixer, which was not nice.
After the patch the strings will be like this:
"Analog Left Main mic Capture Route"
Which show up correctly in alsamixer as "Analog Left Main mic" under the
capture tab.

The second patch cleans up the output amplifier mute/un-mute by adding PGA_E to
all output pins, which were handled by the twl4030_codec_mute function.
Since those gain controls attached to the outputs are not in DAPM domain (yet?)
and they have to be muted/turned off when they are not needed.
Previously all of these (Earpiece PreDrivL/R, CarkitL/R) muted/un-muted at the
same time without checking if the output actually is needed, there could be
cases when the output amplifier is enabled but no actual audio data is routed
there, which could leak some noise on the output.

I know about the changes in core that makes this hassle with the mute
unnecesary (the core sets the BIAS_ON also when any bypass path is active),
I'll be looking at that next.

Peter Ujfalusi (2):
  ASoC: TWL4030: Fix for capture mixer strings
  ASoC: TWL4030: Introduce PGAs for outputs

 sound/soc/codecs/twl4030.c |  155 ++++++++++++++++++++++++--------------------
 1 files changed, 85 insertions(+), 70 deletions(-)

More information about the Alsa-devel mailing list