[alsa-devel] [Uclinux-dist-devel] [PATCH 1/3] new ad1836 codec driver based on asoc

Mike Frysinger vapier.adi at gmail.com
Thu Aug 13 11:34:11 CEST 2009

On Thu, Aug 13, 2009 at 05:22, Mike Frysinger wrote:
> On Thu, Aug 13, 2009 at 05:08, Mark Brown wrote:
>> On Thu, Aug 13, 2009 at 11:41:13AM +0800, Barry Song wrote:
>>> On Wed, Aug 12, 2009 at 9:46 PM, Mark Brown wrote:
>>> > Just "ad1836" - the fact that it's controlled via SPI is clear from the
>>> > fact that this is a struct spi_driver.
>>> I agree the spi structure implies the meaning of spi.  But files in
>>> arch/blackfin/mach... are using names like "xxx-spi" for almost all
>>> spi devices. How about keeping the coherence?
>> Oh dear.  Looks like you've essentially got a choice between being
>> consistent with the rest of the world and being consistent with what the
>> blackfin stuff is doing.
> it really isnt that bad.  the drivers that use "-spi" suffix:
>                .modalias = "ad1836-spi",   # audio
>                .modalias = "ad1938-spi",   # audio
>                .modalias = "ad7147-spi",   # input
>                .modalias = "ad9960-spi",   # dead
>                .modalias = "bfin-lq035q1-spi",  # video
>                .modalias = "fxo-spi",   # dead
>                .modalias = "fxs-spi",   # dead
> dropping the dead devices leaves us with 4 drivers to fix, two of
> which are audio.  should be easy for us to fix.

semi-scratch that.  ive punted the dead devices from our tree, but the
bfin-lq035q1-spi is correct as that device driver requires two things
-- a platform driver named "bfin-lq035q1" and a spi driver named

i'll have to send a patch out for the ad7147-spi since it's been
merged into the input tree iirc, but Barry can handle these two

More information about the Alsa-devel mailing list