[alsa-devel] [PATCH 3/3] new board driver to connect bfin-5xx with ad1836 codec

[Mark Brown]

On Wed, Aug 12, 2009 at 12:32:54PM +0800, Barry Song wrote:

This is OK but...

> +	/* set cpu DAI slots, 8 channels, mask is defined as slot seq */
> +	ret = snd_soc_dai_set_tdm_slot(cpu_dai, 0x73625140, 8);
> +	if (ret < 0)
> +		return ret;

This suggests that there's something really odd going on with your
set_tdm_slot() for the CPU which is likely to make it incompatible with
other implementations and with any core support to handle things like
multi-drop DAIs.  The DAI driver side could certainly use more
documenation explaining what's going on if nothing else...