[alsa-devel] [PATCH 1/2] ASoC: DaVinci: McASP driver enhacements

Mark Brown broonie at opensource.wolfsonmicro.com
Sat Aug 8 10:11:58 CEST 2009

On Fri, Aug 07, 2009 at 10:07:42AM -0400, Chaithrika U S wrote:

> This patch adds support for FIFO configuration.The platform member has a 
> version field which differentiates the McASP on different SoCs. The patch 
> also adds another DAI format to the driver.

You really should split out the DAI format addition into another patch -
there's no code overlap between that and the rest of your changes.
Aside from the issue Troy raised everything seems fine except for one
small issue:

> +
> +	/* McASP FIFO related */
> +	u8	txnumevt;
> +	u8	rxnumevt;

These names don't seem particularly obvious.  If they were chosen to
match the datasheet name then it probably won't be a problem but
otherwise something more like tx_fifo_depth might be easier for people
to figure out.

More information about the Alsa-devel mailing list