[alsa-devel] [RFC] [PATCH] ASoC: OMAP: full duplex mode fix

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Aug 3 11:43:47 CEST 2009


On Mon, Aug 03, 2009 at 11:29:50AM +0300, Jarkko Nikula wrote:
> Janusz Krzysztofik <jkrzyszt at tis.icnet.pl> wrote:

> > +		else
> > +			/* looks like playback already in progress,
> > +			 * start capture by taking it out of error condition */
> > +			omap_mcbsp_pollread(mcbsp_data->bus_id, &buf);

> Minor note: See preferred style for multi-line comments in
> Documentation/CodingStyle. I'm not 100 % sure about the braces but I
> think they are also preferred if there are indented comment lines with
> the single code line.

Indeed; only omit the braces if the *only* thing in the block is a
single statement.


More information about the Alsa-devel mailing list