[alsa-devel] [PATCH] hda: add IbexPeak/Clarkdale HDMI model with static cvt/pin number

Jaroslav Kysela perex at perex.cz
Sat Aug 1 15:17:10 CEST 2009


On Sat, 1 Aug 2009, Wu Fengguang wrote:

> -#define CVT_NID		0x02	/* audio converter */
> -#define PIN_NID		0x03	/* HDMI output pin */
> +static hda_nid_t cvt_nid;	/* audio converter */
> +static hda_nid_t pin_nid;	/* HDMI output pin */

I don't like to use static variables here. I would recommend to use a 
runtime structure to store these values.

 						Jaroslav

-----
Jaroslav Kysela <perex at perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.



More information about the Alsa-devel mailing list