[alsa-devel] [PATCH 16/17] ASoC: Basic split of mpc5200 DMA code out from mpc5200_psc_i2s
broonie at sirena.org.uk
Tue Apr 28 23:01:41 CEST 2009
On Tue, Apr 28, 2009 at 03:59:52PM -0400, Jon Smirl wrote:
> Why are people going to complain about patches to a driver marked
> broken? You can't even compile it without editing the Kconfig.
There is no problem with doing whatever to the driver for 2.6.31 but we
do need to make sure we stay in sync with the other API work that's
going on in 2.6.31.
For 2.6.30 we're outside the merge window so we need to send targetted
fixes for bugs - if we sent your current patches upstream now the
pushback would be that such large refactorings should be merged as part
of the merge window and the bug fixes should be extracted from your
refactoring and merged now. This is the kernel wide development policy,
not an ALSA or ASoC specific one.
Ideally we wouldn't have to mark the driver broken but would instead be
merging bug fixes to it into 2.6.30 - marking it as broken was an
alternative to that.
For the merges the simplest thing would be to fix the current code
before doing the refactoring, though from the sounds of it the final
fixes required for 2.6.30 will be very small in the driver so I'd expect
this can be resolved fairly simply. Changes made in the 2.6.30 branch
get merged into the 2.6.31 branch very quickly so any divergence between
the two branches shouldn't exist for long.
More information about the Alsa-devel