[alsa-devel] [PATCH 16/17] ASoC: Basic split of mpc5200 DMA code out from mpc5200_psc_i2s

Takashi Iwai tiwai at suse.de
Tue Apr 28 17:46:11 CEST 2009

At Tue, 28 Apr 2009 16:23:41 +0100,
Mark Brown wrote:
> From: Jon Smirl <jonsmirl at gmail.com>
> Basic split of mpc5200 DMA code out from i2s into a standalone file.
> [Fixed trailing whitespace -- broonie.]
> Signed-off-by: Jon Smirl <jonsmirl at gmail.com>
> Acked-by: Grant Likely <grant.likely at secretlab.ca>
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>

This patch conflicts with the last patch I merged to add
SNDRV_PCM_INFO_BATCH to some drivers including mpc5200.
(It's in fix/pcm-info-batch branch and not merged to */asoc branch
 yet.  Feel free to pull to your tree by yourself.)
And, the jiffies check shall be anyway fixed in the upstream PCM core
side, thus there is no big merit to hurry to merge the unfinished
changes now.

So, could you back off mpc5200 changes and wait for a while until the
issue regarding PCM jiffies-check is resolved?

Note that the info flag should contain SNDRV_PCM_INFO_BATCH unless the
driver provides the precise position reporting in the pointer
callback.  The flag can be removed once after you implement that
feature, of course.



More information about the Alsa-devel mailing list