[alsa-devel] [RFC PATCH 4/5] ASoC: remove those unnecessary #ifdef CONFIG_PXA3xx .. #endif

Eric Miao eric.y.miao at gmail.com
Thu Apr 23 10:33:34 CEST 2009

On Thu, Apr 23, 2009 at 4:17 PM, Mark Brown <broonie at sirena.org.uk> wrote:
> On Thu, Apr 23, 2009 at 01:06:55PM +0800, Eric Miao wrote:
>> These are unnecessary since the compiler is smart enough to optimize
>> the code away if CONFIG_PXA3xx is not defined, when cpu_is_pxa3xx()
>> will just be expanded to constant 0.
> This isn't done for compiler optimisation - it's done because the
> register bit macros are only defined if PXA3xx support is being built
> in.  I've no problem with removing those guards but without that you'll
> get build failures on PXA2xx.

Yeah, indeed. This is a rush (so the title is RFC), sorry. I'll get those
conditional #ifdef .. #endif removed as well in the ssp-regs.h, it
always makes me upset. And possibly to get ssp-regs.h merged
into ssp.h. No one else now wants to use either one of these
header files.

- eric

More information about the Alsa-devel mailing list