[alsa-devel] [PATCH] us122l: Fix signedness in comparisions

Karsten Wiese fzu at wemgehoertderstaat.de
Fri Apr 17 13:23:05 CEST 2009


Am Freitag 17 April 2009 schrieb Takashi Iwai:
> At Thu, 16 Apr 2009 19:35:01 +0200,
> Karsten Wiese wrote:
> > 
> > Within 2.6.30's mergewindow, struct urb's transfer_buffer_length has become
> > unsigned. This changed an "int > int" comparision to an "unsigned > int" one
> > in snd_usb_122l.
> 
> Does this cause any error, i.e. a real bug?  Otherwise this patch isn't
> needed for stable kernel.

struct urb's transfer_buffer_length is still an int in 2.6.29.1.
This patch wouldn't fix a bug in stable. I agree it is not needed for stable.

Thanks,
Karsten



More information about the Alsa-devel mailing list