[alsa-devel] [PATCH v2 6/6] ARM: DaVinci: ASoC: Introduce platform driver model for dm644x, dm355

[Mark Brown]

On Thu, Apr 16, 2009 at 06:45:33PM -0400, Naresh Medisetty wrote:

> +static struct platform_driver davinci_asoc_driver = {
> +	.probe		= davinci_i2s_probe,
> +	.remove		= davinci_i2s_remove,
> +	.driver		= {
> +		.name	= "davinci-asoc",
> +		.owner	= THIS_MODULE,
> +	},

I suspect that this isn't the best name for the driver - it should
probably be something like davinci-mcasp or possibly davinci-mcasp-audio
or similar.  This isn't the only possible audio device on the DaVinci
(there's an I2S device already) and more may be added in the future.

Other than that this looks OK.