[alsa-devel] [PATCH] ASoC: pxa-ssp: allow setting of dai format 0

Daniel Mack daniel at caiaq.de
Wed Apr 15 20:24:45 CEST 2009

pxa_ssp_set_dai_fmt() currently has an early exit if the desired format
equals the current configuration. This is correct behaviour unless this
function is called with a zero value parameter for the first time.
Zero is a valid value for this function, but the early exit is bogus in
this case.

Hence, set priv->dai_fmt to -1 in the beginning so we can configure the

Signed-off-by: Daniel Mack <daniel at caiaq.de>
Cc: Mark Brown <broonie at sirena.org.uk>
Cc: pHilipp Zabel <philipp.zabel at gmail.com>
 sound/soc/pxa/pxa-ssp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c
index 308a657..de22544 100644
--- a/sound/soc/pxa/pxa-ssp.c
+++ b/sound/soc/pxa/pxa-ssp.c
@@ -806,6 +806,7 @@ static int pxa_ssp_probe(struct platform_device *pdev,
 		goto err_priv;
+	priv->dai_fmt = (unsigned int) -1;
 	dai->private_data = priv;
 	return 0;

More information about the Alsa-devel mailing list