[alsa-devel] [PATCH 1/2] hdspm: metering ioctl fixed
tiwai at suse.de
Wed Apr 15 11:34:57 CEST 2009
At Tue, 14 Apr 2009 17:47:20 +0200,
Florian Faber wrote:
> Metering didn't work before. I know of no application that used this
> ioctl before, so I assume it is safe to modify the structure.
Thanks for the patch. But, could you make a unified diff instead?
If you invoke the diff manually, use -up option.
Also, please give your sign-off. It's mandatory for merging to the
upstream. See $LINUX/Documentation/SubmittingPatches for details.
Finally, please run once $LINUX/scripts/checkpatch.pl before
submitting the patch. This will tell you possible coding-style
issues to fix.
More information about the Alsa-devel