[alsa-devel] [PATCH v2 1/2] alsa: ASoC driver for s6000 I2S interface

Mark Brown broonie at sirena.org.uk
Sat Apr 4 16:37:41 CEST 2009

On Sat, Mar 28, 2009 at 07:47:01PM +0100, Daniel Glöckner wrote:
> This patch adds a driver for the I2S interface found on Stretch s6000
> family processors.

This all looks good - the only concern I have is the issue with the
polarity of the clock signals I mentioned in reply to the machine
driver.  The code in the machine driver does make it look like the I2S
driver is using the opposite polarity to that expected.  If that's not
the case then I guess the thing to do is have some documentation in the
machine driver explaining what's going on.

In order to simplify review I've applied both patches to the s6000
branch of my sound git repository.  Please submit any changes as
incremental patches against that rather than as whole new patches.


More information about the Alsa-devel mailing list