[alsa-devel] [PATCH 3/5] ARM: DaVinci: ASoC: Add the platform devices for ASP

Mark Brown broonie at sirena.org.uk
Thu Apr 2 17:19:41 CEST 2009

On Thu, Apr 02, 2009 at 09:49:31PM -0400, naresh at ti.com wrote:

> Registers the platform devices for ASP on dm355, dm644x and dm646x so that the
> machine driver can probe to get ASP related platform data.

Registering the platform data like this is a good change.  However, it
looks like you're using this to probe the machine driver rather than the
ASoC DAI or platform drivers.  

The structure ought to be that instead of calling snd_soc_register_dai()
in the module_init() function the McASP drivers register platform
drivers for themselves there.  Then the resources can be acquired and
snd_soc_register_dai() called in the probe function of the driver,
meaning the machine driver doesn't need to get involved in passing the
data around at all.

More information about the Alsa-devel mailing list