[alsa-devel] [PATCH] ASoC: Fix cs4270 error path
tiwai at suse.de
Tue Sep 30 13:08:31 CEST 2008
At Tue, 30 Sep 2008 11:38:55 +0200,
Jean Delvare wrote:
> Hi Takashi,
> On Tue, 30 Sep 2008 10:53:20 +0200, Takashi Iwai wrote:
> > At Tue, 30 Sep 2008 10:31:37 +0200,
> > Jean Delvare wrote:
> > > I fear there's some confusion there. There are two different patches
> > > fixing error paths in cs4270. One fixing a fallout from the new-style
> > > i2c driver conversion (in cs4270_i2c_probe), under name "ASoC: Fix
> > > another cs4270 error path". This one you pushed to Linus last night.
> > >
> > > But there's another one, named "ASoC: Fix cs4270 error path",
> > > originally posted by myself on August 31st, fixing the error path of
> > > cs4270_probe. This is the one Timur was just acking, but I do _not_ see
> > > it in your queue, so I suspect you missed it. I can resend it if it
> > > helps.
> > Oh, OK, then I must have missed that. Could you repost?
> Will do in a minute.
> > And, this *must* go to 2.6.27, or not?
> It could go in 2.6.27, certainly, but I wouldn't say it *must* go
> there. The patch is "only" fixing an error path, which by definition
> isn't supposed to be needed unless something unexpected happens, in
> which case the driver probably won't work anyway. So it doesn't deserve
> delaying 2.6.27, and sending a pull request to Linus for just that
> patch would probably be overkill. But if you get the opportunity to
> send such a pull request for another problem, then it makes sense to
> include this cs4270 fix as well.
There is one quirk fix for a Dell laptop, so I'm going to put it in
the next pull request before 2.6.27 final.
More information about the Alsa-devel