[alsa-devel] [PATCH 0/5] [RFC] ALSA ASoC Support for TLVaic23b audio codec

[Troy Kisky]

Mark Brown wrote:
> On Mon, Sep 29, 2008 at 09:47:10AM -0700, Troy Kisky wrote:
> 
>> Great. I just finished the same thing for davinci but using spi.
>> I was waiting until the adc issue I mentioned yesterday was resolved before posting it.
>> I'm glad I won't have to now. But my board also has I2c, just not with this
> 
> It'd be great if you could work with Arun to ensure that all the
> features which you are using are supported in the driver - it looks like
> at least SPI support will need to be added.
> 
>> codec. Can the I2c code be moved into the board directory? I have my spi code
>> in the board directory and just pass the write function pointer. i.e.
> 
> No, the I2C and SPI support should both be part of the driver.  The
> driver should just be modified to allow both I2C and SPI support to be
> compiled in and let the board driver register the appropriate one at run
> time.
> 
Can you please explain to me why they should both be part of the codec driver?


Thanks
Troy