[alsa-devel] [PATCH] ASoC: Fix cs4270 error path
tiwai at suse.de
Mon Sep 29 15:48:03 CEST 2008
At Mon, 29 Sep 2008 08:42:15 -0500,
Timur Tabi wrote:
> On Sun, Aug 31, 2008 at 7:42 AM, Jean Delvare <khali at linux-fr.org> wrote:
> > The error path in cs4270_probe/cs4270_remove is pretty broken:
> > * If cs4270_probe fails, codec is leaked.
> > * If snd_soc_register_card fails, cs4270_i2c_driver stays registered.
> > * If I2C support is enabled but no I2C device is found, i2c_del_driver
> > is never called (neither in cs4270_probe nor in cs4270_remove.)
> > Fix the first 2 problems by implementing a clean error path in
> > cs4270_probe and jumping to its labels as needed. Fix the 3rd problem
> > by removing the condition to call i2c_del_driver in cs4270_remove.
> > Signed-off-by: Jean Delvare <khali at linux-fr.org>
> Acked-By: Timur Tabi <timur at freescale.com>
> Takashi, this patch needs to go into 2.6.27 as well. Sorry about
> that. I don't know how I missed so many problems with my code.
Don't worry, I already put it to the queue, too.
More information about the Alsa-devel