[alsa-devel] [PATCH 4/5] [RFC] ALSA ASOC adds destination and source port for dma

[Jarkko Nikula]

On Mon, 29 Sep 2008 15:23:52 +0530
"ext Arun KS" <arunks at mistralsolutions.com> wrote:

> Adds destination and source ports for dma which is required for OMAP1
> 
> Signed-off-by: Arun KS <arunks at mistralsolutions.com>
> ---
>  sound/soc/omap/omap-pcm.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
>  	err = omap_request_dma(dma_data->dma_req, dma_data->name,
>  			       omap_pcm_dma_irq, substream, &prtd->dma_ch);
> +
>  	if (!cpu_is_omap1510()) {

Accidentally added line? Actually it pointed out that line after it
should include test for err before linking channel with itself.

	if (!err && !cpu_is_omap1510()) {

> +		dma_params.dst_port		= OMAP_DMA_PORT_MPUI;
>  	} else {
...
> +		dma_params.src_port		= OMAP_DMA_PORT_MPUI;
>  	}

I don't have OMAP1 HW at hand to test but looks ok to me. And this port
variable is used only with OMAP1's.


Jarkko
--
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html