[alsa-devel] [PATCH 1/1] ALSA: ASoC: Fix wrong param when call snd_soc_test_bits

Mark Brown broonie at opensource.wolfsonmicro.com
Sat Sep 27 18:33:02 CEST 2008

On Sat, Sep 27, 2008 at 08:43:16PM +0800, Richard Zhao wrote:

> Fix wrong param when call snd_soc_test_bits in function dapm_mux_update_power.

So...  This patch doesn't actually do what the changelog entry here
says: the arguments to snd_soc_test_bits() remain the same before and
after your change.

> -		if (!path->name || ! e->texts[val])
> +		if (!path->name || !e->texts[mux])
>  			continue;

What this is actually doing is changing the enum text examined to be
indexed by mux (the value of the enumerated control) rather than val
(the bitmask in the register).  This looks like a good change but I want
to double check with a test system.

More information about the Alsa-devel mailing list