[alsa-devel] [PATCH 1/1] ASoC Blackfin: fix bug - Audio Latency on AD1981 with MMAP enabled

Bryan Wu cooloney at kernel.org
Sat Sep 27 15:40:58 CEST 2008


On Sat, Sep 27, 2008 at 5:33 PM, Mark Brown <broonie at sirena.org.uk> wrote:
> On Sat, Sep 27, 2008 at 04:58:09PM +0800, Bryan Wu wrote:
>> From: Cliff Cai <cliff.cai at analog.com>
>
>> With MMAP enabled (DMA mode) on the AD1981, there is +/- 250ms of delay between
>> writing data to alsa and audio starts coming out of the AD1981.
>>
>> Copy more data to local buffer before starting DMA
>
>> Signed-off-by: Cliff Cai <cliff.cai at analog.com>
>> Signed-off-by: Bryan Wu <cooloney at kernel.org>
>
> Acked-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
>
> but
>
>> + *
>> + * Revision history
>> + *      6th June 2008 Initial version
>> + *      25th Sep 2008 fix latency when enable mmap
>>   */
>
> it'd be good to drop the in-code changelogs - we're already tracking the
> history of the code with git and they're likely to end up providing an
> inaccurate history due to people not updating them (this applies to most
> of the Blackfin code).  There were in-code changelogs in ASoC in the past
> from the time it was out of tree but they shouldn't be required now.
>

OK, I will submit a new patch by moving the changelogs to git log.

Thanks
-Bryan


More information about the Alsa-devel mailing list