[alsa-devel] Ответ: [PATCH 01/24] sound/pci: coding style fixes: ac97
tiwai at suse.de
Wed Sep 10 13:55:13 CEST 2008
At Tue, 9 Sep 2008 19:15:36 +0400,
Alexander Beregalov wrote:
> 2008/9/9, Takashi Iwai <tiwai at suse.de>:
> >> - <asm/io.h> -> <linux/io.h>
> >> - remove trailing whitespaces
> >> - convert comments
> >> Only compile tested.
> > Thanks for patches. It takes some time to check all of them because
> > apparently you tested only compilation :)
> > I'll let you know when these are merged.
> Yes, sure.
> I did not just modify files and test compilation, I certainly read all
> that changes, but it would be better if someone inspects them too.
One thing I noticed that spaces around open parentheses aren't always
fixed, e.g. in sound/pci/cs46xx/*. Could you fix them?
BTW, I'll likely postpone some (or most) of these patches until
shortly before the final push to the upstream, because these spacing
changes break all other upcoming patches. That is, this can be even
worse than nothing in such a case.
So, applying this at the last would be a better option.
More information about the Alsa-devel