[alsa-devel] [PATCH] phase and juli coding style fixes (more coming up)

Takashi Iwai tiwai at suse.de
Sun Sep 7 12:45:23 CEST 2008

At Sun, 7 Sep 2008 12:29:08 +0200,
=?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> Sorry for missing that one, I'm not able to compile alsa for some
> reason. Some change in alsa-kmirror don't work with current
> alsa-driver on my 2.6.26 kernel.

Don't use alsa-kmirror then.  The submitted patch should have been
tested properly.  If untested, please describe it clearly.

> I will be more careful next time. Just wondering, what did I miss?

A missing semicolon in a line.

> BTW, I was wondering: do you sync your tree (sound-2.6 or
> sound-unstable-2.6) with 2.6.27 Linus's tree? Because, if that's the
> case, then I might be tempted to switch to using that tree as my
> "everyday kernel".

The standard procedure is to pull the upstream tree onto yours.
That is, run

   % git pull git://git.kernel.org/pub/.../tiwai/sound-2.6.git master

then the changes in sound-2.6.git tree will be merged into yours.


> 2008/9/7 Takashi Iwai <tiwai at suse.de>:
> > Thanks.  Applied now.
> >
> > BTW, there was a typo in your patch that broke the compile.
> > Please check the build properly before submitting the patch.
> >
> >
> > Takashi
> >
> -- 
> Vedran Miletić

More information about the Alsa-devel mailing list