[alsa-devel] [PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver

Mark Brown broonie at sirena.org.uk
Fri Sep 5 15:10:50 CEST 2008

On Fri, Sep 05, 2008 at 06:21:35PM +0800, Bryan Wu wrote:

> +	/* Maybe the dummy buffer descriptor ring is damaged */
> +	sport->dummy_rx_desc->next_desc_addr = \
> +			(unsigned long)(sport->dummy_rx_desc+1);

Here and elsewhere in this driver you've got continuation characters
which aren't need.  I've fixed this up locally (and some additional
checkpatch/coding standards things) here and in other patches in the

Otherwise the patch series looks good to go, thanks - I'm just about to
review the codec driver patch that it depends upon.

More information about the Alsa-devel mailing list