[alsa-devel] [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec

Mark Brown broonie at sirena.org.uk
Tue Sep 2 22:31:21 CEST 2008

On Tue, Sep 02, 2008 at 09:08:09PM +0100, Liam Girdwood wrote:
> On Tue, 2008-09-02 at 19:54 +0100, Mark Brown wrote:

> > OK, a comment to that effect somewhere (perhaps in set_sysclk() which
> > only accepts 26MHz) probably wouldn't go amiss.

> The codec set_sysclk() should also accept 19.2MHz and 38.4MHz otherwise
> return -EINVAL. It should also have a nice comment too :)

Ideally, yes but it looked like that'd need additional code to set the
codec up to use them.  Obviously the ideal thing would be if the driver
supports everything the chip does.

More information about the Alsa-devel mailing list