[alsa-devel] [PATCH 4/4] ALSA: add dummy function to support shared mmap in nommu Blackfin arch
cooloney at kernel.org
Tue Sep 2 11:59:40 CEST 2008
On Tue, Sep 2, 2008 at 5:41 PM, Takashi Iwai <tiwai at suse.de> wrote:
> At Tue, 2 Sep 2008 11:16:37 +0800,
> Cai, Cliff wrote:
>> > @@ -3419,5 +3426,6 @@ const struct file_operations snd_pcm_f_ops =
>> > .compat_ioctl = snd_pcm_ioctl_compat,
>> > .mmap = snd_pcm_mmap,
>> > .fasync = snd_pcm_fasync,
>> > + .get_unmapped_area = dummy_get_unmapped_area,
>> > }
>> > };
>> >I don't think adding this dummy get_unmapped_area unconditionally for
>> every driver is good. This overrides the default
>> But without this dummy function,shared mmap on nommu arch would
>> fail,refer to validate_mmap_request() in mm/nommu.c.
> Yes, I know it's needed for nommu. That's why I wrote
> "unconditionally" in the above.
>> May be we can add a kernel config item to include or not include this
>> function depending on non-mmu or mmu arch.
> Checking CONFIG_MMU may suffice?
Right, I post a v2 patch including this checking.
More information about the Alsa-devel