[alsa-devel] [PATCH 3/4] ASOC: WM8731 codec: add SPI support as well as I2C

Alan Horstmann gineera at aspect135.co.uk
Mon Sep 1 15:52:08 CEST 2008

We have just started trying this out as an alternative to i2c, and picked out 
the following:

On Wednesday 27 August 2008 10:39, Bryan Wu wrote:
> -#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
> +#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE) && !defined

I think this needs extra brackets round the ||'s before the && thus:

> +#if (defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)) && !defined

in order to force use of SPI when (CONFIG_SND_SOC_WM8731_SPI) and (CONFIG_I2C) 
are both defined.  Or have we misunderstood the intention?  This is in 2 
other places also in the patch.


More information about the Alsa-devel mailing list