[alsa-devel] [PATCH] aoa i2sbus: don't overwrite module parameter

Johannes Berg johannes at sipsolutions.net
Thu Oct 23 16:49:59 CEST 2008


On Thu, 2008-10-23 at 18:47 +0200, Takashi Iwai wrote:
> At Thu, 23 Oct 2008 13:57:39 +0200,
> Johannes Berg wrote:
> > 
> > We shouldn't modify a global variable here.
> > 
> > Signed-off-by: Johannes Berg <johannes at sipsolutions.net>
> 
> Applied.  This seems a good thing to go to 2.6.28, so I'll put
> it to the next pull request.

Heh, well, it doesn't _really_ matter, it's just cleaner for reporting
to userspace via sysfs what the module parameters are. It's been that
way since I wrote it over two years ago, so ... up to you, I don't
really care.

Thanks for taking it.

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20081023/c18f3f10/attachment.sig 


More information about the Alsa-devel mailing list