[alsa-devel] [PATCH 2/4] ASoC: AD1980 codec: add multi-channel function support
broonie at sirena.org.uk
Thu Oct 23 12:34:00 CEST 2008
On Thu, Oct 23, 2008 at 05:01:58PM +0800, Bryan Wu wrote:
> From: Cliff Cai <cliff.cai at analog.com>
> We added multi-channel function to this codec driver and Blackfin ASoC driver as well.
> It was tested on Blackfin hardware.
The changelog entry is now inaccurate since this was split out from the
machine. This looks mostly OK but...
> + /*power on LFE/CENTER/Surround DACs*/
> + ext_status = ac97_read(codec, AC97_EXTENDED_STATUS);
> + ac97_write(codec, AC97_EXTENDED_STATUS, ext_status&~0x3800);
...this should have spaces around the & - I'm rather surprised that
checkpatch.pl doesn't pick that up (I just tested and it doesn't).
Acked-by: Mark Brown <broonie at opensource.wolfsonicro.com>
More information about the Alsa-devel