[alsa-devel] [PATCH] ALSA: emu10k1: fix device names for Live!/Audigy1/2/4/E-mu and coding style

Takashi Iwai tiwai at suse.de
Mon Oct 20 08:15:20 CEST 2008


At Sun, 19 Oct 2008 14:33:53 +0200,
=?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> 
> Changelog:
> * added missing SBxxxx, CTxxxx, PCxxx and MAEMxxxx where they were missing,
> and fixed some of them which were wrong (according to kx.inf, which is pretty
> accurate compared to anything out there)
> * fixed device names to make them more consistent across various cards
> * fixed lots of coding style errors and some warnings, now it is down to:
> checkpatch.pl-0.24 --no-tree --file --strict --terse emu10k1_main.c
> total: 0 errors, 62 warnings, 7 checks, 2074 lines checked

Could you split your changes to separate patches?
They shouldn't be mixed up in a single patch.

Also, make sure that your change itself passes the checkpatch.pl...


thanks,

Takashi


More information about the Alsa-devel mailing list