[alsa-devel] [patch] bugfix: SOUND: SOC: OMAP: Add support for Gumstix Overo

David Brownell david-b at pacbell.net
Fri Oct 3 17:11:33 CEST 2008


From: David Brownell <dbrownell at users.sourceforge.net>

Get rid of bogus ASOC boot messages on non-Overo boards,
such as with a kernel built for both Overo and Beagle.

Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>
Acked-By: Steve Sakoman <steve at sakoman.com>
---
I'm not sure where the four patches for Overo support are
in the ALSA queue (that's how they'll merge, yes?) but I'll
suggest this one merge into the initial "overo.c" submit...

 sound/soc/omap/overo.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

--- a/sound/soc/omap/overo.c
+++ b/sound/soc/omap/overo.c
@@ -107,11 +107,11 @@ static int __init overo_soc_init(void)
 {
 	int ret;
 
-	printk(KERN_INFO "overo SoC init\n");
 	if (!machine_is_overo()) {
-		printk(KERN_ERR "Not Overo!\n");
+		pr_debug("Not Overo!\n");
 		return -ENODEV;
 	}
+	printk(KERN_INFO "overo SoC init\n");
 
 	overo_snd_device = platform_device_alloc("soc-audio", -1);
 	if (!overo_snd_device) {
@@ -135,13 +135,12 @@ err1:
 
 	return ret;
 }
+module_init(overo_soc_init);
 
 static void __exit overo_soc_exit(void)
 {
 	platform_device_unregister(overo_snd_device);
 }
-
-module_init(overo_soc_init);
 module_exit(overo_soc_exit);
 
 MODULE_AUTHOR("Steve Sakoman <steve at sakoman.com>");


More information about the Alsa-devel mailing list