[alsa-devel] Kcontrols for ASoC TWL4030 CODEC

[Mark Brown]

On Thu, Nov 20, 2008 at 06:12:56PM +0530, naveen krishna ch wrote:

>  static const struct snd_kcontrol_new twl4030_snd_controls[] = {
> -    SOC_DOUBLE_R("Master Playback Volume",
> -         TWL4030_REG_ARXL2PGA, TWL4030_REG_ARXR2PGA,
> -        0, 127, 0),
> -    SOC_DOUBLE_R("Capture Volume",
> -         TWL4030_REG_ATXL1PGA, TWL4030_REG_ATXR1PGA,
> -        0, 127, 0),
> +
> +    /* Master Playback Volume Controls */
> +        SOC_DOUBLE_R("Master PLayback Course Gain",
> +                TWL4030_REG_ARXL2PGA, TWL4030_REG_ARXR2PGA,
> +                6, 3, 0),
> +

Please see the comments I made in response to your original posting -
there look to be problems with your indentation here and your control
names should conform to the ALSA control naming standard in:

	Documentation/sound/alsa/ControlNames.txt