[alsa-devel] [PATCH 5/8] ASoC: Fix BUGS in Blackfin AC97 DAI

Hennerich, Michael Michael.Hennerich at analog.com
Tue Nov 18 12:58:55 CET 2008


>> sport_handle is a global and not allocated my kmalloc.
>
>There's no reference to sport_handle in the patch...

Sorry - spurious comment please ignore.

-Michael

>-----Original Message-----
>From: Mark Brown [mailto:broonie at sirena.org.uk]
>Sent: Tuesday, November 18, 2008 12:54 PM
>To: Bryan Wu
>Cc: tiwai at suse.de; Cliff Cai; alsa-devel at alsa-project.org; linux-
>kernel at vger.kernel.org; Michael Hennerich
>Subject: Re: [alsa-devel] [PATCH 5/8] ASoC: Fix BUGS in Blackfin AC97
DAI
>
>On Tue, Nov 18, 2008 at 04:18:19PM +0800, Bryan Wu wrote:
>> From: Michael Hennerich <michael.hennerich at analog.com>
>
>> sport_handle is a global and not allocated my kmalloc.
>
>There's no reference to sport_handle in the patch...
>
>> A probe function should have a clean return 0 path.
>
>...only this.


More information about the Alsa-devel mailing list