[alsa-devel] [PATCH] ALSA SOC driver for s3c24xx with uda1341

[chri]

On Mon, Nov 10, 2008 at 8:22 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Mon, Nov 10, 2008 at 01:34:52PM +0000, Mark Brown wrote:
>> > +   xtal = clk_get(NULL, "xtal");
>> > +   pclk = clk_get(NULL, "pclk");
>>
>> This should be done in the init function for the device and should
>> really check the return value in case it can't get the clock for some
>> reason.  Ideally there'd be a dev there, but I'd need to check if the
>> s3c24xx stuff does that.
>
> And should not be passing a NULL device to clk_get().
>

ack. I just picked the *wrong* example driver as a template  :-/

-- 
Christian Pellegrin, see http://www.evolware.org/chri/
"Real Programmers don't play tennis, or any other sport which requires
you to change clothes. Mountain climbing is OK, and Real Programmers
wear their climbing boots to work in case a mountain should suddenly
spring up in the middle of the computer room."